feat(v2): allow navbar links to show active style by specifying a base path #2299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 1c1fd31 |
lex111
approved these changes
Feb 19, 2020
Yes, but this is much more flexible and keeps the generic components generic, which is better for long term maintainability. |
yangshun
changed the title
yangshun
added
the
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Attempts to fix #2222 and as an alternative to #2243. I think this solution is better than in #2243 as it is a general solution and can be useful for other kinds of pages as well.
If approved, I'll add docs for this feature and add this new property to the templates.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Click on docs links in preview.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)